Add __getstate__ and __setstate__ methods in PluginsApp to fix #329 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@markkuleinio if you have a chance would you merge in the latest changes and see if the test suite passes now? Thanks :) |
|
No success: https://pastebin.com/yLmBEjCa |
|
Ah! You don't have docker installed! OK.. this is something I can work around. I apologize.. I should have thought of that. I'll send up a PR to skip integration tests if docker is not present. |
|
FYI however I do think the tests run via github workflows should pass if you merge upstream master in to this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #329 (pickling problems with PluginsApp).