Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of #224 #292

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Fix of #224 #292

merged 1 commit into from
Dec 29, 2020

Conversation

Dimaqa
Copy link
Contributor

@Dimaqa Dimaqa commented Sep 25, 2020

So #224 still happens, becaise exception happens in req.get(), not in Request creation
This will fix it

@Dimaqa Dimaqa changed the title should catch error on get, not on req creation Fix of #224 Sep 25, 2020
@Dimaqa
Copy link
Contributor Author

Dimaqa commented Sep 25, 2020

But after such fix endpoint class will also return None in bad requests with typos, such as dcim.deivces and etc :(

zachmoody
zachmoody approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@zachmoody zachmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, thanks for catching that.

@zachmoody zachmoody merged commit 636ddeb into netbox-community:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmoody zachmoody zachmoody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dimaqa @zachmoody