Implement Record.__getitem__() #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation returns the provided key. This is confusing for the user as it is unexpected. Instead, we turn ourselves into a dict and return the expected value. This is not really efficient but the whole logic is already implemented in other functions. Fix netbox-community#281.
vincentbernat
force-pushed
the
fix/getitem
branch
from
d8537ea
to
eddf4d2
Compare
|
Well that's elegant. Nice! Thanks for the PR. |
|
Hey, @vincentbernat - Thanks a ton for this sweet PR! 😄 Would you please shoot me an email when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation returns the provided key. This is confusing
for the user as it is unexpected. Instead, we turn ourselves into a
dict and return the expected value. This is not really efficient but
the whole logic is already implemented in other functions.
Fix #281.