Fixes #11046: Restrict length of indexed search values #11076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
requested changes
Dec 1, 2022
jeremystretch
force-pushed
the
11046-search-indexes
branch
from
b8f0e23
to
a37d638
Compare
|
After some discussion we've opted to simply remove the existing indexes for now, as they're of little utility currently. After some future testing we'll revisit and add indexes most likely to be utilized during common search operations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11046
This adjusts the indexes on
CachedValue.valueto index only values less than 1024 bytes in length. This may need further experimentation but it seemed like a reasonable cut-off.