Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #10356 backplane connections #10554

Merged

Conversation

phurrelmann
Copy link
Contributor

Fixes: #10356

  • Added new interface-types for backplane connections. The interface types are grouped as "Ethernet (backplane)'. This is inline with other Ethernet types. I refrained from using "IEE 802.3ap" in the group description as its not adequate. the SIG 802.3ap only was involved for the 1G and 10G speeds, but the newer standards were developed in different SIG.

  • Added new port-type backplane to enable modeling of bldecenter-passthru modules (e.g. SBM-25G-P10 which hast 10/25 backplane front ports and 40G/100G fiber rear-ports and acts like a passive media converter).

  • Added new cable-type backplane to model the connection for backplane ports/interfaces.

@@ -1151,6 +1176,7 @@ class PortTypeChoices(ChoiceSet):
TYPE_URM_P4 = 'urm-p4'
TYPE_URM_P8 = 'urm-p8'
TYPE_OTHER = 'other'
TYPE_BACKPLANE = 'backplane'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of #10356 is limited to the introduction of new interface types. Any new port/cable types would need to be proposed separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I forgot to include the new port type initially and only were missing them when testing and modeling my requirements. I'll create a new ticket for that.
But the new cable type is included in the ticket description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the cable type. Would "stacking" maybe be a better name for this? I've just never heard the term "backplane cable;" open to other opinions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the new port type and will create a followup ticket to have that added.

A backplane connection is no stacking (like in virtual-chassis, etc). It is merely a direct physical connection without any cable :/ Nevertheless the cable description was adjusted to hopefully better describe it. If you come up with a better/more appropriate name feel free to change that. As said there actually is no cable in use, when a backplane connection is established. It's just a shortcoming of the connection/cable model in netbox and I'm not questioning that nor do I propose any changes. I'd just like to have a way to filter and search for backplane connections/cables, so it needs an identifier. The type "other" wouldn't match reality too, imho.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between a backplane connection and a module? For something like modular Cisco chassis (Nexus 7700 and Catalyst 9500), they just use slots that slide into the backplace, but I'm curious as to the reasoning for modeling the backplane?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho a module is more or less limited to networking equipment (at least that's what it's designed for). My use case comes from modular server systems e.g. bladecenters. You don't want to model a blade as a module. A blade is a fully fledged child device that goes into device-bays of a chassis.

E.g. https://www.supermicro.com/en/products/superblade/module/SBI-4129P-C2N.cfm
This blade has 2x 10G interfaces that are backplane connections to the switch/passthru/whatever is plugged into the bladecenter chassis.

An ethtool output of one interface on those blades show:

user# ethtool eno1
Settings for eno1:
	Supported ports: [ Backplane ]
	Supported link modes:   1000baseKX/Full
	                        10000baseKR/Full
	Supported pause frame use: Symmetric Receive-only
	Supports auto-negotiation: Yes
	Supported FEC modes: Not reported
	Advertised link modes:  1000baseKX/Full
	                        10000baseKR/Full
	Advertised pause frame use: No
	Advertised auto-negotiation: Yes
	Advertised FEC modes: Not reported
	Speed: 10000Mb/s
	Duplex: Full
	Auto-negotiation: on
	Port: None
	PHYAD: 0
	Transceiver: internal
	Supports Wake-on: g
	Wake-on: g
        Current message level: 0x00000007 (7)
                               drv probe link
	Link detected: yes

This whole PR is for modeling those kind of devices.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A blade is a fully fledged child device that goes into device-bays of a chassis.

These are modeled in NetBox as child devices. There is no need to model a discrete connection as it's implied by the parent/child relationship.

I think we should omit the "backplane" connection type as it's too ambiguous, and easily confused with e.g. passive direct attach cabling.

netbox/dcim/choices.py Show resolved Hide resolved
@jeremystretch
Copy link
Member

I've omitted the "backplane" cable type per the comments above just to unblock this PR and get the interface types added.

@jeremystretch jeremystretch merged commit 3a62fd4 into netbox-community:develop Nov 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new interface and cable types to model direct interface connections to backplanes
3 participants