Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all change logging resources from extras to core #16388

Closed
jeremystretch opened this issue Jun 3, 2024 · 0 comments
Closed

Move all change logging resources from extras to core #16388

jeremystretch opened this issue Jun 3, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v4.1

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Move all resources related to change logging from the extras app to core. This will entail moving the following:

  • The ObjectChange model
  • Relevant views and API endpoints
  • The event_tracking() context manager

Justification

Although originally introduced as an optional "extra" feature in NetBox, change logging quickly become a core function of the application as it matured. It no longer makes sense for it to live under extras.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Jun 3, 2024
@jeremystretch jeremystretch added this to the v4.1 milestone Jun 3, 2024
@jeremystretch jeremystretch self-assigned this Jun 12, 2024
jeremystretch added a commit that referenced this issue Jun 13, 2024
@jeremystretch
Initial work on #16388
e7d1b7d
@jeremystretch jeremystretch mentioned this issue Jun 13, 2024
Merged
jeremystretch added a commit that referenced this issue Jun 17, 2024
@jeremystretch
Closes #16388: Move change logging resources from extras to core (#…
853d990 
…16545)

* Initial work on #16388

* Misc cleanup
jeremystretch added a commit that referenced this issue Jun 17, 2024
@jeremystretch
#16388: Fix migration bug
e12edd7
jeremystretch added a commit that referenced this issue Jun 17, 2024
@jeremystretch
#16388: Rename database indexes & constraints
388ba3d
jeremystretch added a commit that referenced this issue Aug 1, 2024
@jeremystretch
#16388: Move change logging signal handlers into core
8e6987e
@jeremystretch jeremystretch mentioned this issue Sep 3, 2024
Merged
@mlebreuil mlebreuil mentioned this issue Sep 10, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v4.1
Development

No branches or pull requests
1 participant
@jeremystretch