Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk edit of Interfaces of VMs without cluster fails #14363

Closed
larsux opened this issue Nov 28, 2023 · 0 comments · Fixed by #14367
Closed

Bulk edit of Interfaces of VMs without cluster fails #14363

larsux opened this issue Nov 28, 2023 · 0 comments · Fixed by #14367
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@larsux
Copy link

larsux commented Nov 28, 2023

NetBox version

v3.6.5

Python version

3.8

Steps to Reproduce

  1. Create VM and assign only a Site, not a Cluster
  2. Create Interface for VM
  3. Mark Interface and click on "Edit Selected"

Expected Behavior

Edit form for selected VM Interface(s) appear

Observed Behavior

Exception Window with the following Content:

<class 'AttributeError'>

'NoneType' object has no attribute 'site'

Python version: 3.8.10
NetBox version: 3.6.5
Plugins: 
  netbox_demo: 0.3.1

When generating the bulk edit form, the site is extracted from the cluster of the virtual machine, which fails if no cluster is assigned to the VM:

  File "/opt/netbox/netbox/virtualization/forms/bulk_edit.py", line 272, in __init__
     site = interface.virtual_machine.cluster.site
AttributeError: 'NoneType' object has no attribute 'site'
@larsux larsux added the type: bug A confirmed report of unexpected behavior in the application label Nov 28, 2023
@abhi1693 abhi1693 added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Nov 28, 2023
@jeremystretch jeremystretch self-assigned this Nov 28, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 28, 2023
jeremystretch added a commit that referenced this issue Nov 28, 2023
@jeremystretch
Fixes #14363: Fix bulk editing of interfaces assigned to VM with no c…
553f8e2 
…luster
@jeremystretch jeremystretch mentioned this issue Nov 28, 2023
Merged
jeremystretch added a commit that referenced this issue Nov 29, 2023
@jeremystretch
Fixes #14363: Fix bulk editing of interfaces assigned to VM with no c…
792b353 
…luster
This was referenced Nov 30, 2023
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #14363: Fix bulk editing of interfaces assigned to VM with no cluster netbox-community/netbox
3 participants
@abhi1693 @jeremystretch @larsux