Weight Import Fix #1187
Merged
Weight Import Fix #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2023
Merged
Closed
Merged
Closed
Closed
etherwrangler
pushed a commit
to etherwrangler/devicetype-library
that referenced
this pull request
Jul 16, 2023
* weight schema configuration changes * updated weight/weight unit definitions to compy with import expectations. * updated readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this discussion in regards to why this is necessary.
The NetBox API requires weight to be modelled in the following format:
This PR will migrate all current weight definitions to the supported format, and will also fix the test cases.