-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Lenovo Servers SR530/SR550/X3250M6 and fix SR650 #1062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxzz
changed the title
Lenovo server
add Lenovo Servers SR530/SR550/X3250M6 and fix SR650
Jan 20, 2023
danner26
requested changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VGA adapters are not console ports, and thus should not be modelled how you currently are. Please remove those from the definitions
danner26
added
the
status: revisions needed
This issue requires additional information to be actionable
label
Jan 20, 2023
Added ThinkSystem to model name
Added ThinkSystem to model name
Added ThinkSystem to model name
danner26
approved these changes
Jan 21, 2023
danner26
added
status: accepted
and removed
status: revisions needed
This issue requires additional information to be actionable
labels
Jan 21, 2023
Thank you for your contribution! |
mjpereira602
pushed a commit
to mjpereira602/devicetype-library
that referenced
this pull request
Feb 22, 2023
…y#1062) * fix SR650 unit height , add comments * add Lenovo SR530 SR550 X3250M6 * Update system_x3250_M6.yaml * remove VGA port * Update SR530.yaml Added ThinkSystem to model name * Update SR550.yaml Added ThinkSystem to model name * Update SR650.yaml Added ThinkSystem to model name Co-authored-by: Daniel W. Anner <[email protected]>
etherwrangler
pushed a commit
to etherwrangler/devicetype-library
that referenced
this pull request
Jul 16, 2023
…y#1062) * fix SR650 unit height , add comments * add Lenovo SR530 SR550 X3250M6 * Update system_x3250_M6.yaml * remove VGA port * Update SR530.yaml Added ThinkSystem to model name * Update SR550.yaml Added ThinkSystem to model name * Update SR650.yaml Added ThinkSystem to model name Co-authored-by: Daniel W. Anner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Lenovo Servers SR530/SR550/X3250M6 and fix SR650.
The product datasheet can be found below.
SR530 https://lenovopress.lenovo.com/lp1045.pdf
SR550 https://lenovopress.lenovo.com/lp1046.pdf
SR650 https://lenovopress.lenovo.com/lp1050.pdf
x3250M6 https://lenovopress.lenovo.com/lp0096.pdf