Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Lenovo Servers SR530/SR550/X3250M6 and fix SR650 #1062

Merged
merged 9 commits into from
Jan 21, 2023

Conversation

nxzz
Copy link
Contributor

@nxzz nxzz commented Jan 20, 2023

This pull request adds Lenovo Servers SR530/SR550/X3250M6 and fix SR650.

The product datasheet can be found below.
SR530 https://lenovopress.lenovo.com/lp1045.pdf
SR550 https://lenovopress.lenovo.com/lp1046.pdf
SR650 https://lenovopress.lenovo.com/lp1050.pdf
x3250M6 https://lenovopress.lenovo.com/lp0096.pdf

@nxzz nxzz changed the title Lenovo server add Lenovo Servers SR530/SR550/X3250M6 and fix SR650 Jan 20, 2023
Copy link
Member

@danner26 danner26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VGA adapters are not console ports, and thus should not be modelled how you currently are. Please remove those from the definitions

device-types/Lenovo/SR530.yaml Outdated Show resolved Hide resolved
device-types/Lenovo/SR550.yaml Outdated Show resolved Hide resolved
device-types/Lenovo/SR650.yaml Outdated Show resolved Hide resolved
device-types/Lenovo/system_x3250_M6.yaml Outdated Show resolved Hide resolved
@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Jan 20, 2023
@nxzz nxzz requested a review from danner26 January 21, 2023 04:43
Added ThinkSystem to model name
Added ThinkSystem to model name
Added ThinkSystem to model name
@danner26 danner26 added status: accepted and removed status: revisions needed This issue requires additional information to be actionable labels Jan 21, 2023
@danner26
Copy link
Member

Thank you for your contribution!

@danner26 danner26 merged commit fe7844e into netbox-community:master Jan 21, 2023
mjpereira602 pushed a commit to mjpereira602/devicetype-library that referenced this pull request Feb 22, 2023
…y#1062)

* fix SR650 unit height , add comments

* add Lenovo SR530 SR550 X3250M6

* Update system_x3250_M6.yaml

* remove VGA port

* Update SR530.yaml

Added ThinkSystem to model name

* Update SR550.yaml

Added ThinkSystem to model name

* Update SR650.yaml

Added ThinkSystem to model name

Co-authored-by: Daniel W. Anner <[email protected]>
etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
…y#1062)

* fix SR650 unit height , add comments

* add Lenovo SR530 SR550 X3250M6

* Update system_x3250_M6.yaml

* remove VGA port

* Update SR530.yaml

Added ThinkSystem to model name

* Update SR550.yaml

Added ThinkSystem to model name

* Update SR650.yaml

Added ThinkSystem to model name

Co-authored-by: Daniel W. Anner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants