Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-NetBox 3.3 features #928

Closed
wants to merge 1 commit into from
Closed

Remove pre-NetBox 3.3 features #928

wants to merge 1 commit into from

Conversation

hollow
Copy link

@hollow hollow commented Jan 24, 2023

Related Issue

netbox-community/pynetbox#521

Contrast to Current Behavior

Support for secrets has been removed

Proposed Release Note Entry

Support for secrets has been removed

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@rodvand
Copy link
Contributor

rodvand commented Jan 24, 2023 •
edited
Loading

Thanks for the PR! Secrets is actually a pre 3.0 feature so I think it is safe to remove this now. We do however need to mark the option as deprecated in the module, not just remove it.

@hollow
Copy link
Author

hollow commented Jan 24, 2023

@rodvand I wasn't sure about the required process so I started by simply removing it, since the update to pynetbox 7.x today broke my ansible playbooks 🙈

@sc68cal
Copy link
Contributor

sc68cal commented Jan 24, 2023

This brings up a question, should we be putting constraints on our dependencies, like pynetbox, since they do make API changes that break things?

@sc68cal sc68cal mentioned this pull request Jan 24, 2023
Closed
@bluikko
Copy link
Contributor

bluikko commented Jan 25, 2023

@sc68cal Definitely!
Even better would be if these 2 projects would coordinate together since they are totally intertwined.

This change has broken everyone's netbox.netbox...

@jefvantongerloo
Copy link

Following.

Can confirm, pynetbox upgrade broke my calls through nb_lookup modules.
Found a solution in downgrading to 6.6.2.

It would be great to synchronise the pynetbox requirement to assure compatibility with each netbox collection and netbox version release.

rfdrake added a commit to rfdrake/awx-netbox-ee that referenced this pull request Feb 5, 2023
@rfdrake
force pynetbox to be < version 7
2de5308 
nb_lookup is broken with 7.0.1 because they removed private_key_file.
The ansible_modules team is working to deprecate the old private_key
support and fix things, but the workaround for now is to stay on
pynetbox<7.

netbox-community/ansible_modules#928
@ryanmerolle
Copy link
Contributor

ryanmerolle commented Feb 25, 2023 •
edited
Loading

relates to #878

@hollow hollow closed this by deleting the head repository Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hollow @rodvand @sc68cal @bluikko @jefvantongerloo @ryanmerolle