docker build + add vendors choices as env var #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2021 14:46
|
Looks good to me! I'm sure @minitriga will approve as well. This is great for people who (gasp! haha) may not have a local installation of python. |
|
Thx @ndom91 ! I've added the docker specific documentation. Would it be possible to also host this image on a container registry ? |
|
If you want to setup the CI required with Github actions then we can get something hosted yes. |
|
Sorry $dayjob has me very busy working on other things right now so I try to look when i can. Thanks for all the good work @k0rventen and @ndom91 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a Dockerfile making possible to run the project as a container.
It also enables the selection of vendors through an
VENDORSenv var, with the same behavior as the--vendorsarg, so that everything is configurable through env var.Regarding the documentation, I think a new section could be added, but I wanted to check if you were ok with the feature beforehand.
thx!