Remove hardcoded console=ttyS0,115200 configuration from VyOS boot configuration #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Equinix Metal This change removes the console=ttyS0,115200 configuration from the VyOS boot configuration in roles/netbootxyz/templates/menu/boot.cfg.j2. This setting is causing issues with VyOS installation on Equinix Metal as the console is not visible during boot. Console configuration is done in https://github.com/netbootxyz/netboot.xyz/blob/development/roles/netbootxyz/templates/menu/boot.cfg.j2 Example https://github.com/netbootxyz/netboot.xyz/blob/development/roles/netbootxyz/templates/menu/boot.cfg.j2#L120
|
Thanks, this should be handled by the ${cmdline} flag but was probably getting superseded by the hardcoded console. |
antonym
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the console=ttyS0,115200 configuration from the VyOS boot configuration in roles/netbootxyz/templates/menu/boot.cfg.j2. This setting is causing issues with VyOS installation on Equinix Metal as the console is not visible during boot.
Console configuration is done in https://github.com/netbootxyz/netboot.xyz/blob/development/roles/netbootxyz/templates/menu/boot.cfg.j2
Examples:
x86_64 https://github.com/netbootxyz/netboot.xyz/blob/development/roles/netbootxyz/templates/menu/boot.cfg.j2#L120
arm64 https://github.com/netbootxyz/netboot.xyz/blob/development/roles/netbootxyz/templates/menu/boot.cfg.j2#L129