Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Refactor peers to use store methods #2893

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

[management] Refactor peers to use store methods #2893

wants to merge 75 commits into from

Conversation

bcmmbaga
Copy link
Contributor

@bcmmbaga bcmmbaga commented Nov 14, 2024 •
edited
Loading

Describe your changes

Remove calls to get and save whole account in peers operations.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@bcmmbaga
Refactor setup key handling to use store methods
389c961 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add lock to get account groups
78044c2 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add check for regular user
1a5f3c6 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
get only required groups for auto-group validation
931521d 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add account lock and return auto groups map on validation
f8b5eed 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
refactor account peers update
106fc75 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Refactor groups to use store methods
0a70e4c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
refactor GetGroupByID and add NewGroupNotFoundError
8126d95 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix tests
ac05f69 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'feature/get-account-refactoring' into setupkey-get-acco…
40af1a5 
…unt-refactoring

# Conflicts:
#	management/server/sql_store.go
@bcmmbaga
Merge branch 'setupkey-get-account-refactoring' into groups-get-accou…
d58cf50 
…nt-refactoring

# Conflicts:
#	management/server/sql_store.go
@bcmmbaga
Add AddPeer and RemovePeer methods to Group struct
7100be8 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Preserve store engine in SqlStore transactions
6dc185e 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Run groups ops in transaction
bdeb95c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix missing group removed from setup key activity
3ed8b9c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'setupkey-get-account-refactoring' into groups-get-accou…
cc04aef 
…nt-refactoring
@bcmmbaga
fix merge
871500c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Refactor posture checks to remove get and save account
174e07f 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix refactor
d54b696 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix tests
601d429 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'main' into groups-get-account-refactoring
010a8bf 
# Conflicts:
#	management/server/group.go
#	management/server/group/group.go
#	management/server/setupkey.go
#	management/server/sql_store.go
#	management/server/status/error.go
#	management/server/store.go
@bcmmbaga
fix merge
664d138 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix sonar
ab00c41 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Change setup key log level to debug for missing group
113c21b 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Retrieve modified peers once for group events
d23b5c8 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'groups-get-account-refactoring' into policy-get-account…
ffce48c 
…-refactoring
@bcmmbaga
Refactor policy get and save account to use store methods
0c0fd38 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Fix tests
2d7f08c 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Add tests
2806d73 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'groups-get-account-refactoring' into posturechecks-get-…
00023bf 
…account-refactoring
@bcmmbaga
Merge branch 'main' into groups-get-account-refactoring
92b9e11 
# Conflicts:
#	management/server/group.go
@bcmmbaga
Fix typo
4ef3890 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Add locks and remove log
51c1ec2 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'main' into groups-get-account-refactoring
1ff8f61
@bcmmbaga
Merge branch 'groups-get-account-refactoring' into posturechecks-get-…
d4c7124 
…account-refactoring
@bcmmbaga
run peer ops in transaction
a61e9da 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
remove duplicate store method
a2fb274 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
fix peer fields updated after save
a2a49bd 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
add tests
48edfa6 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'posturechecks-get-account-refactoring' into policy-get-…
6dd56e3 
…account-refactoring
@bcmmbaga
Use update strength and simplify check
ec6438e 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
prevent changing ruleID when not empty
df98c67 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
prevent duplicate rules during updates
b60e2c3 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga bcmmbaga force-pushed the peers-get-account-refactoring branch 2 times, most recently from e8a5d16 to 9950683 Compare November 18, 2024 20:35
@bcmmbaga
fix tests
20fc8e8 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga bcmmbaga force-pushed the peers-get-account-refactoring branch from 9950683 to 20fc8e8 Compare November 18, 2024 21:54
@bcmmbaga bcmmbaga marked this pull request as ready for review November 19, 2024 07:09
@bcmmbaga
fix lint
0ee56e1 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga bcmmbaga force-pushed the peers-get-account-refactoring branch from 21f57c0 to 4abf9ad Compare November 21, 2024 13:49
@bcmmbaga
Use UTC time in test
82746d9 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga bcmmbaga force-pushed the peers-get-account-refactoring branch from 4abf9ad to 82746d9 Compare November 21, 2024 14:15
@bcmmbaga
Merge branch 'main' into policy-get-account-refactoring
bdb2a76 
# Conflicts:
#	management/server/policy.go
#	management/server/posture_checks_test.go
#	management/server/sql_store.go
#	management/server/sql_store_test.go
#	management/server/status/error.go
#	management/server/store.go
#	management/server/testdata/extended-store.sql
@bcmmbaga
Merge branch 'policy-get-account-refactoring' into dns-get-account-re…
79822cd 
…factoring
@bcmmbaga
Merge branch 'dns-get-account-refactoring' into nameserver-get-accoun…
72bfc9d 
…t-refactoring
@bcmmbaga
Merge branch 'main' into nameserver-get-account-refactoring
2e6bbac 
# Conflicts:
#	management/server/sql_store_test.go
#	management/server/status/error.go
#	management/server/testdata/extended-store.sql
Base automatically changed from nameserver-get-account-refactoring to main November 26, 2024 16:39
@bcmmbaga
Merge branch 'nameserver-get-account-refactoring' into peers-get-acco…
b213987 
…unt-refactoring

# Conflicts:
#	management/server/account.go
#	management/server/http/peers_handler.go
#	management/server/peer.go
@bcmmbaga
Merge branch 'main' into peers-get-account-refactoring
21561a2 
# Conflicts:
#	management/server/sql_store_test.go
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 New issues
4 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcmmbaga