fix(crud): TypeOrm Cache was not working #688
Open
+302
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewiko
force-pushed
the
cache-is-not-working
branch
from
1994b1b
to
9018e0d
Compare
|
Hello @zMotivat0r, |
atjsh
approved these changes
May 31, 2021
|
Any plans on merging this? I'm facing the same issue. |
feat(envs): migrate repo from nestjsx to rewiko
feat(readme): update readme with release information
rewiko
force-pushed
the
cache-is-not-working
branch
from
1a2072b
to
3e8c0b5
Compare
|
Merged and released on my own repo Cache is not working rewiko#3 |
|
Why isnt this merged. a simple debug of the library clearly shows the bug? Any ideas when this will be fixed? |
|
Can the reviewers provide some update on this Merge request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeOrm Cache is not working.
builder.getQueryAndParameters()returns an array of 2 items, first one is the SQL generated and second one is an array of given parameters. linkTypeOrm cache function can have either 2 parameters with the first one the key name as a string and the TTL or only the latter and the key will be generated automatically.
2 options are possible the first one would be to concatenate the getQueryAndParameters array or let TypeOrm generates the key.
Fixes #397 #407 #569
The cache should not be used to get resource while we try to update/delete them.