Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed typeorm mongodb health check fails with mongodb>=5.0 #2399

Merged

Conversation

supaflyENJOY
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If you try to run a health check for TypeORM with type: 'mongodb' with mongodb >= 5.0 you will always get an error:
{"status":"error","info":{},"error":{"database":{"status":"down","message":"timeout of 5000ms exceeded"}},"details":{"database":{"status":"down","message":"timeout of 5000ms exceeded"}}}
It happens because in the MongoDB module callback API has been removed. You can read more here.

What is the new behavior?

With this small fix health check passes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@supaflyENJOY
Copy link
Contributor Author

It looks like this issue was also mentioned here

@supaflyENJOY supaflyENJOY force-pushed the fix-typeorm-mongodb-health-check branch from df97a8f to 9608fd5 Compare October 4, 2023 01:29
@BrunnerLivio
Copy link
Member

Thanks!

@BrunnerLivio BrunnerLivio merged commit b6026c2 into nestjs:master Nov 26, 2023
@BrunnerLivio
Copy link
Member

Released with v10.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants