Memory leak in grpc health indicator #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channels reference themselves with timeout's, meaning that they cannot be garbage collected by v8. This is a workaround that stops us from creating more and more channels; thus fixing a memory leak.
Tony133
approved these changes
Sep 14, 2023
|
Some cool charts from our staging environment; guess when the change rolled out 😝
|
|
Really well-done investigation! Thank you so much, will release this later today 🙏 |
BrunnerLivio
pushed a commit
that referenced
this pull request
Sep 14, 2023
Channels reference themselves with timeout's, meaning that they cannot be garbage collected by v8. This is a workaround that stops us from creating more and more channels; thus fixing a memory leak. Resolves #2329
BrunnerLivio
pushed a commit
that referenced
this pull request
Sep 14, 2023
Channels reference themselves with timeout's, meaning that they cannot be garbage collected by v8. This is a workaround that stops us from creating more and more channels; thus fixing a memory leak. Resolves #2329
|
Released with v10.1.0 🎉 |
|
Thanks @SophiaH67!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the grpc health indicator creates a new client and a new channel with each time the health gets checked.
This is a problem, since
@grpc/grpc-js's channels reference themselves in a timeout. This means that they can NOT be garbage collected by v8(tested with NodeJS).What is the new behavior?
New behaviour is that channels get stored on creation in a map. The key is the service name which is provided, which has to be unique anyway since it is also used as a key in the final json output. By caching the channels we prevent ourselves from creating new ones, thus fixing the memory leak.
Does this PR introduce a breaking change?
Other information