Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(manifest): add optional peerDependencies #2072

Merged
merged 1 commit into from
Nov 17, 2022
Merged

chore(manifest): add optional peerDependencies #2072

merged 1 commit into from
Nov 17, 2022

Conversation

gabormagyar
Copy link
Contributor

@gabormagyar gabormagyar commented Nov 16, 2022

closes #2071

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

Issue Number: #2071

Does this PR introduce a breaking change?

  • Yes
  • No

More Info

I gathered all usages of the checkPackages function to see what packages it could be called with, and added those as optional peerDeps.

We could (and probably should) specify what versions are compatible, but I lack the knowledge to do that. Adding them as "*" is already an improvement.

@BrunnerLivio
Copy link
Member

Ohhh that is awesome, I've been looking for optional peer dependencies for so long. Didn't know it was here. I'll merge it asap and create a beta release so I can test it real quick.

@BrunnerLivio BrunnerLivio merged commit adfd8bc into nestjs:master Nov 17, 2022
@BrunnerLivio
Copy link
Member

BrunnerLivio commented Nov 17, 2022

This has been released with 9.1.3
🎉

@gabormagyar gabormagyar deleted the patch-1 branch November 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional peerDependencies are not declared in manifest
3 participants