-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(health-indicator): add mikro-orm health indicator #1876
Conversation
LGTM so far. I'll check it out locally asap :) Thanks a lot, really appreicated! |
The unit tests failed here but not sure why. Does work locally though 😉 |
@jbw they failed in node10 because the operator |
Downgrading Mikro that far back to v2 or v3 won't work either as the library is not compatible with newer versions. v4 onwards supports Node 14+ @BrunnerLivio @micalevisk I noticed the e2e tests support only v14. I wonder if it is safe to drop v10 and v12 from the unit tests? |
Kamil still want to support node 10. So I guess isn't that safe to remove those unit tests in Maybe we can drop the support for node10 only for the mikro-orm part somehow. And then we should verify that in the action so we could skip it |
I'm doing some further experiments on this. Theoretically, it should be possible to keep Node v10 support with Terminus - unless you use MikroOrm off course - since we optionally load third-party dependencies. I'll close this PR and continue it over at #1879. Off course, contributions are welcome there as well. FYI:
I am trying it this way currently, no luck so far. terminus/lib/health-indicator/database/mikro-orm.health.ts Lines 105 to 106 in a2a50a1
Will need to dig deeper in the following days |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Adds
mikro-orm
health indicatorIssue Number: #1877
Does this PR introduce a breaking change?
Other information