Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose HealthCheckStatus public type #1858

Merged
merged 1 commit into from
Jun 19, 2022
Merged

feat: expose HealthCheckStatus public type #1858

merged 1 commit into from
Jun 19, 2022

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented May 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If we want to import the type HealthCheckStatus, we'll need to write
import type { HealthCheckStatus } from '@nestjs/terminus/dist/health-check'
or
HealthCheckResult['status']

What is the new behavior?

I'm not sure if this was intentional because there's a @publicApi annotation on that type

/**
* @publicApi
*/
export type HealthCheckStatus = 'error' | 'ok' | 'shutting_down';

Does this PR introduce a breaking change?

  • Yes
  • No

@micalevisk
Copy link
Member Author

hey @BrunnerLivio can you please review this when you have time

@BrunnerLivio
Copy link
Member

Sorry missed this one, will release in a sec!

@BrunnerLivio BrunnerLivio merged commit 76514a2 into nestjs:master Jun 19, 2022
@micalevisk micalevisk deleted the patch-1 branch June 19, 2022 15:47
@BrunnerLivio
Copy link
Member

Released via 8.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants