fix: HealthCheckError in sync HealthIndicatorFunction

Fixes #2083
nestjs · Nov 23, 2022 · ee06275 · ee06275
1 parent 07cd184
commit ee06275
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/health-check/health-check-executor.service.spec.ts b/lib/health-check/health-check-executor.service.spec.ts
@@ -20,6 +20,14 @@ const unhealthyCheck = async (): Promise<HealthIndicatorResult> => {
   });
 };
 
+const unhealthyCheckSync = () => {
+  throw new HealthCheckError('error', {
+    unhealthy: {
+      status: 'down',
+    },
+  });
+};
+
 describe('HealthCheckExecutorService', () => {
   let healthCheckExecutor: HealthCheckExecutor;
 
@@ -70,6 +78,26 @@ describe('HealthCheckExecutorService', () => {
       });
     });
 
+    it('should return a result object with errors with sync indicator function', async () => {
+      const result = await healthCheckExecutor.execute([
+        () => unhealthyCheckSync(),
+      ]);
+      expect(result).toEqual<HealthCheckResult>({
+        status: 'error',
+        info: {},
+        error: {
+          unhealthy: {
+            status: 'down',
+          },
+        },
+        details: {
+          unhealthy: {
+            status: 'down',
+          },
+        },
+      });
+    });
+
     it('should return a result object without errors and with errors', async () => {
       const result = await healthCheckExecutor.execute([
         () => unhealthyCheck(),

diff --git a/lib/health-check/health-check-executor.service.ts b/lib/health-check/health-check-executor.service.ts
@@ -60,7 +60,7 @@ export class HealthCheckExecutor implements BeforeApplicationShutdown {
     const results: HealthIndicatorResult[] = [];
     const errors: HealthIndicatorResult[] = [];
 
-    const result = await Promise.allSettled(healthIndicators.map((h) => h()));
+    const result = await Promise.allSettled(healthIndicators.map(async (h) => h()));
 
     result.forEach((res) => {
       if (res.status === 'fulfilled') {