Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(platform): Explicitly added a new line type to tests #555

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

boenrobot
Copy link

This allows tests to run normally on Windows.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Other... Please describe:

What is the current behavior?

The new line of tests was left as the default. However, on Windows, TypeScript generates files with Windows line endings, making the test expectations not match.

Issue Number: N/A

What is the new behavior?

New line is explicitly set to linux line endings, so that regardless of what platform the tests are executed on, the tests will pass.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This allows tests to run normally on Windows.
@kamilmysliwiec kamilmysliwiec merged commit 3eb841f into nestjs:master Feb 10, 2020
@kamilmysliwiec
Copy link
Member

Thanks!

@boenrobot boenrobot deleted the win-tests branch February 10, 2020 14:16
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants