fix: @ApiSchema inheritance #3164
Merged
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the correct @ApiSchema name is used when inheriting from a base class.
arabold
commented
Nov 13, 2024
Comment on lines
+421
to
+423
| @ApiSchema({ | ||
| name: 'UpdateUser' | ||
| }) |
There was a problem hiding this comment.
Interesting enough, the case without an @ApiSchema decorator in the child class had been tested. Just not the case when both the parent and the child class have a decorator set.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the correct @ApiSchema name is used when inheriting from a base class.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3160
What is the new behavior?
The correct schema name will be used
Does this PR introduce a breaking change?
Other information
There's also a fix necessary for
getSchemaPath(get-schema-ath.util.ts). However I have not found a single test for these utils, so I didn't add one but applied the exact same fix.