Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@nestjs/swagger): defaults api tag to controller name #3017

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nhomble
Copy link
Contributor

@nhomble nhomble commented Jul 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

comment was added, but I'll follow up with actual doc update if they approach looks good

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

controller names are ignored

Issue Number: 3011

What is the new behavior?

users can opt-in to have the controller name be added to the tag list

Does this PR introduce a breaking change?

  • Yes
  • No

it's opt-in

Other information

@nhomble
Copy link
Contributor Author

nhomble commented Jul 23, 2024

from the manual test

image

we don't dedupe in case the dev explicitly adds more tags

image

@nhomble
Copy link
Contributor Author

nhomble commented Jul 24, 2024

@kamilmysliwiec do you prefer to do feedback in github or should I join discord?

If the changes (especially the config parameter) look good, I'll update the docs!

@nhomble
Copy link
Contributor Author

nhomble commented Jul 30, 2024

I'm going to follow up this week with doc changes.


Followed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants