Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: exclusive minimum and exclusive maximum are numbers" #2994

Merged
merged 1 commit into from
Jul 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions e2e/api-spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,10 @@
"required": true,
"in": "query",
"schema": {
"exclusiveMinimum": 0,
"exclusiveMaximum": 10000,
"minimum": 0,
"maximum": 10000,
"exclusiveMaximum": true,
"exclusiveMinimum": true,
"title": "Page",
"format": "int32",
"default": 0,
Expand Down Expand Up @@ -481,8 +483,10 @@
"in": "query",
"required": true,
"schema": {
"exclusiveMinimum": 0,
"exclusiveMaximum": 10000,
"minimum": 0,
"maximum": 10000,
"exclusiveMaximum": true,
"exclusiveMinimum": true,
"title": "Page",
"format": "int32",
"default": 0,
Expand Down
6 changes: 4 additions & 2 deletions e2e/src/cats/dto/pagination-query.dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ export enum LettersEnum {

export class PaginationQuery {
@ApiProperty({
exclusiveMinimum: 0,
exclusiveMaximum: 10000,
minimum: 0,
maximum: 10000,
title: 'Page',
exclusiveMaximum: true,
exclusiveMinimum: true,
format: 'int32',
default: 0
})
Expand Down
4 changes: 2 additions & 2 deletions lib/interfaces/open-api-spec.interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,9 @@ export interface SchemaObject {
title?: string;
multipleOf?: number;
maximum?: number;
exclusiveMaximum?: boolean | number;
exclusiveMaximum?: boolean;
minimum?: number;
exclusiveMinimum?: boolean | number;
exclusiveMinimum?: boolean;
maxLength?: number;
minLength?: number;
pattern?: string;
Expand Down