Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function for enum types #2935

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

slukes
Copy link
Contributor

@slukes slukes commented Apr 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When using enum values that are dynamic, the value returned depends on the order that modules are imported in

Issue Number: #2786

What is the new behavior?

enum can be a function which is called at the moment that the document is generated.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@slukes
Copy link
Contributor Author

slukes commented May 2, 2024

Hey @kamilmysliwiec I see you closed the associated issue. Did you mean to approve the PR at the same time?

@slukes
Copy link
Contributor Author

slukes commented Jun 3, 2024

@kamilmysliwiec up 😄

@kamilmysliwiec kamilmysliwiec merged commit adb6561 into nestjs:master Jul 1, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants