Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: fix options type of specific response decorators #2897

Closed
wants to merge 1 commit into from

Conversation

hekystyle
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

It's not obvious from .d.ts file that status field in options is overridden in every Api*Response decorator.

Issue Number: N/A

What is the new behavior?

status field is omited from ApiResponseOptions type for each Api*Response decorator.

Does this PR introduce a breaking change?

  • Yes
  • No

It can cause TypeScript errors I guess? Fix: remove status field from options when using Api*Response decorator.

Other information

@hekystyle
Copy link
Author

Similar to #2877

@hekystyle hekystyle closed this Mar 30, 2024
@hekystyle hekystyle deleted the fix-api-responses-types branch March 30, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant