Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add response example #2871

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

lit26
Copy link
Contributor

@lit26 lit26 commented Mar 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

@ApiNotFoundResponse(
	{
	description: 'Unauthorized.',
	type: HttpExceptionDTO,
	example: {
		message: 'Unauthorized',
		status: 401
	}
)

Cannot add example

Issue Number: #2260

What is the new behavior?

Will add example alongside $ref

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@lit26 lit26 changed the title Feature/add response example feat: add response example Mar 11, 2024
@shaunhurryup
Copy link

@kamilmysliwiec @micalevisk This PR has been proposed for over a year, why hasn't it been merged or received any response?

@insidedw
Copy link

We want you guys to have a code review quickly, because if it gets merged, our code will be simpler.

@kamilmysliwiec kamilmysliwiec merged commit 56622e8 into nestjs:master Jul 1, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

@lit26 lit26 deleted the feature/add-response-example branch July 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants