Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(introspectComments): Enhanced comment parsing for error response #2835

Conversation

lit26
Copy link
Contributor

@lit26 lit26 commented Feb 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

@throws tag will not add ApiResponse decorator

Issue Number: N/A

What is the new behavior?

Add ApiResponse decorator if @throws exist.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 6c5a7f6 into nestjs:master Jul 1, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

@lit26 lit26 deleted the feature/add-response-decorator-from-comment branch July 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants