Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring and extending the support of validation property assignments #2742

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Dec 6, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Only a limited number of decorators are supported, and are listed directly in the model-class visitor.
Issue Number: N/A

What is the new behavior?

1- Extended it to support the following decorators:

  • Contains
  • ArrayNotEmpty
  • ArrayUnique
  • ArrayMaxSize
  • ArrayMinSize
  • IsDivisibleBy
  • IsEmail
  • IsMobilePhone
  • IsJSON
  • IsUrl
  • IsUuid
  • IsBase64
  • IsCreditCard
  • IsCurrency
  • IsAscii
  • IsHexColor
  • IsHexadecimal,

2- After adding these decorators the file became too long and hard to read, that's why I thought of refactoring it to separate the concerns and isolate the facts ( decorators to properties mappings ) so it's not flooding the visitor, and easier to read and maintain.

If you think this refactor is unnecessary or anything could be improved, let me know.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@iifawzi
Copy link
Contributor Author

iifawzi commented Jan 22, 2024

Hi, are there any updates on this?

@kamilmysliwiec kamilmysliwiec merged commit 35bd06f into nestjs:master Oct 23, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants