Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for string mapping types #2608

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat: add support for string mapping types #2608

merged 1 commit into from
Sep 11, 2023

Conversation

bc-m
Copy link

@bc-m bc-m commented Sep 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

String mappings like Uppercase<string> or Lowercase<string> are not recognized as string type.

Issue Number: #2606

What is the new behavior?

String mappings are recognized as string type.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Closes #2606

@bc-m
Copy link
Author

bc-m commented Sep 10, 2023

Checks should succeed if #2512 has been merged. @kamilmysliwiec Feel free to ping me if I can rebase this.

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 27eb8e2 into nestjs:master Sep 11, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Uppercase<string>" and "Lowercase<string>" by treating them as normal strings
3 participants