Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebases #983 (Add decorator to allow specification of the schema type name #983) #2427

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

mothershipper
Copy link
Contributor

See #983 and #1596

TL;DR; cherry-picked the commits onto the latest master branch to resolve conflicts in the PR. Original author info should be maintained on the commits.

Stefan Radacovsky added 2 commits May 12, 2023 15:41
You can use @ApiSchema to set a custom schema name.
Custom schema names are not inherited.
You can use @ApiSchema to set a custom schema name.
Custom schema names are not inherited.
@mothershipper
Copy link
Contributor Author

Just double checked and it seems like the docs PR also needs a rebasing -- @kamilmysliwiec I'm a bit tied up this morning, but happy to get to that either late today or tomorrow. Could we perhaps merge this (when approved) as a kind of forcing-function to get the docs PR pushed through as well?

@RobbyUitbeijerse
Copy link

hey there! Was just looking for this functionality, any chance this is ready to be merged? If there's something I can help with let me know.

@GuilhermeGuitte
Copy link

Hey there! Any news regarding this feature?

@GuilhermeGuitte
Copy link

@kamilmysliwiec Do you think this feature is something you are looking forward to integrate on this package? Thanks!

@CSenshi
Copy link

CSenshi commented Nov 9, 2023

@kamilmysliwiec any plans on merging this PR in the near future?

@wespen
Copy link

wespen commented Jan 2, 2024

Any updates on when will this PR be merged?

@nikhilro
Copy link

nikhilro commented Jan 14, 2024

Gentle bump, would appreciate this. Further, would love to modify the title too.

@giancarlo-dm
Copy link

I don't want to sound harsh, but I need this too and and this this feature was requests multiple times already and it goes as back as 2021 and we are 2024 already. Why is this taking so long?

@ThatsARapp
Copy link

@kamilmysliwiec Anything in particular holding this up? I would love to have this right about now. Happy to work on any changes if that will get the ball rolling again.

Copy link

@sleeyax sleeyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cheezytony
Copy link

Hi All!
Any updates or reasons why this PR hasn't been merged yet?

It's a widely requested feature.

@nestjs nestjs locked and limited conversation to collaborators Feb 29, 2024
@kamilmysliwiec kamilmysliwiec merged commit 2e06012 into nestjs:master Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.