Fix: doc versioning by header #2063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micalevisk
reviewed
Sep 2, 2022
package.json
Outdated
| @@ -40,7 +40,7 @@ | |||
| "@nestjs/platform-fastify": "9.0.11", | |||
| "@types/jest": "28.1.7", | |||
| "@types/js-yaml": "4.0.5", | |||
| "@types/lodash": "4.14.182", | |||
| "@types/lodash": "4.14.184", | |||
There was a problem hiding this comment.
why do we need to upgrade this? 🤔
There was a problem hiding this comment.
It's already updated on master, it's a fail from my rebase: 67c78e4
There was a problem hiding this comment.
coud you rebase it again? looks like we got some conflicts to fix
added 4 commits
September 12, 2022 12:56
4 tasks
|
Apologies for not reviewing this sooner! Could you please resolve conflicts? Also, any chance we can add an e2e test too (with enabled versioning by header)? |
|
Any updates on this? Looking forward to being able to use it! :) |
|
is there anything remaining to merge this? happy to contribute to this PR to get it merged |
|
We're still waiting for e2e tests to be added |
|
Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 1495
What is the new behavior?
Versioning documentation is now working for header versioning.
Does this PR introduce a breaking change?
Other information