Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make introspectComments work with tab indentation #1706

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

chromey
Copy link

@chromey chromey commented Dec 1, 2021

introspectComments did not properly parse comments when source files used tab indentation

fixes #1705

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1705

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

introspectComments did not properly parse comments when source files used tab indentation

fixes nestjs#1705
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM. I'll let Kamil weigh in his thoughts as well

@kamilmysliwiec kamilmysliwiec merged commit a525819 into nestjs:master Jan 25, 2022
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

introspectComments does not play nice with tab indentation
4 participants