Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use defaultVersion as a fallback to controller version #1632

Merged
merged 2 commits into from
Oct 22, 2021
Merged

fix: use defaultVersion as a fallback to controller version #1632

merged 2 commits into from
Oct 22, 2021

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Oct 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1631

image

The feature introduced in nestjs/nest#8128 is not taking in count

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 0762f74 into nestjs:master Oct 22, 2021
@micalevisk micalevisk deleted the hotfix/controller-default-version branch October 22, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants