Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@nestjs/swagger) Change created document property order #1373

Conversation

StenCalDabran
Copy link

Ensure that the paths property comes before the components property,
as this may lead to several strange display bugs in swagger-ui.
See swagger-api/swagger-ui#5972 or
swagger-api/swagger-ui#3325 (comment)

Closes #1369

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1369

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Ensure that the paths property comes before the components property,
as this may lead to several strange display bugs in swagger-ui.
See swagger-api/swagger-ui#5972 or
swagger-api/swagger-ui#3325 (comment)

Closes nestjs#1369
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 8.0.0 June 18, 2021 11:36
@kamilmysliwiec
Copy link
Member

LGTM. Merged to 8.0.0 branch

@kamilmysliwiec kamilmysliwiec merged commit f78bbfe into nestjs:8.0.0 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse order of properties <paths> and <components> in generated document may avoid display problems
3 participants