Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default status for api-response decorator #1149

Merged

Conversation

coolsamk7
Copy link
Contributor

@coolsamk7 coolsamk7 commented Jan 25, 2021

set default value for the status code in ApiResponse
decorator if status code not pass.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1017

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

set default value for the status code in ApiResponse
decorator if status code  not pass.
@kamilmysliwiec
Copy link
Member

LGTM. Merged to 8.0.0 branch

@kamilmysliwiec kamilmysliwiec merged commit 5f300c7 into nestjs:8.0.0 Jun 18, 2021
@coolsamk7
Copy link
Contributor Author

Thank you @kamilmysliwiec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants