Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Arrays and objects are not managed properly when located in first level of @Query() #1113

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

arnaud-cortisse
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

See #1112

What is the new behavior?

Arrays and objects are now correctly interpreted as such in @query()

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@andrewdhazlett
Copy link

@arnaud-cortisse does this work properly with the Try it out feature of Swagger UI? It looks like the Swagger docs want you to use a content block along with encoding types to specify JSON query strings.

Here's a workaround I've been using in the meantime, but unfortunately it doesn't let me associate it to the DTO (I'd like to avoid using $ref here if possible)
image

@BenK93
Copy link

BenK93 commented Feb 5, 2024

I'm having the same problem using in the @Body as well. is it the same problem?

@abdulkaderelrawas
Copy link

any news about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants