Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: includes additional properties in schema #1109

Merged
merged 1 commit into from
Dec 28, 2020
Merged

fix: includes additional properties in schema #1109

merged 1 commit into from
Dec 28, 2020

Conversation

foray1010
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

additionalProperties in ApiProperty is not moved to schema in swagger.json, which is invalid

What is the new behavior?

shouldm move additionalProperties to schema

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@foray1010
Copy link
Contributor Author

@kamilmysliwiec would be great if we can have a new release with this fix :)

@kamilmysliwiec kamilmysliwiec merged commit ffa5adf into nestjs:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants