fix: apply optional decorator to metadata factory props

nestjs · Jul 27, 2023 · d8b9dd3 · d8b9dd3
1 parent 9d8588a
commit d8b9dd3
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/lib/type-helpers/partial-type.helper.ts b/lib/type-helpers/partial-type.helper.ts
@@ -34,6 +34,15 @@ export function PartialType<T>(classRef: Type<T>): Type<Partial<T>> {
         mapValues(metadata, (item) => ({ ...item, required: false }))
     );
 
+    if (PartialTypeClass[METADATA_FACTORY_NAME]) {
+      const pluginFields = Object.keys(
+        PartialTypeClass[METADATA_FACTORY_NAME]()
+      );
+      pluginFields.forEach((key) =>
+        applyIsOptionalDecorator(PartialTypeClass, key)
+      );
+    }
+
     fields.forEach((key) => {
       const metadata =
         Reflect.getMetadata(
@@ -59,12 +68,5 @@ export function PartialType<T>(classRef: Type<T>): Type<Partial<T>> {
     applyFields(fields);
   });
 
-  if (PartialTypeClass[METADATA_FACTORY_NAME]) {
-    const pluginFields = Object.keys(PartialTypeClass[METADATA_FACTORY_NAME]());
-    pluginFields.forEach((key) =>
-      applyIsOptionalDecorator(PartialTypeClass, key)
-    );
-  }
-
   return PartialTypeClass as Type<Partial<T>>;
 }