Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): scoped factories should not fail with optional deps #9922

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Jul 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jul 12, 2022

Pull Request Test Coverage Report for Build 9caa7317-9204-4b85-8112-58c572e79ec8

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.91%

Totals Coverage Status
Change from base Build 38481207-2780-42b7-acb9-e7c705b97a47: 0.0%
Covered Lines: 6029
Relevant Lines: 6420

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 76923e7 into master Jul 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/scoped-factories-optional-deps branch July 12, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants