feat(common): file type validator #9832
Merged
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add regex support when checking a file mime-type
Pull Request Test Coverage Report for Build db003176-c1db-4d09-a5f7-494250e09f5d
💛 - Coveralls |
micalevisk
approved these changes
Jun 25, 2022
Tony133
approved these changes
Jun 25, 2022
| @@ -25,6 +29,8 @@ export class FileTypeValidator extends FileValidator<FileTypeValidatorOptions> { | |||
| return false; | |||
| } | |||
|
|
|||
| return (file.mimetype as string).endsWith(this.validationOptions.fileType); | |||
| return Boolean( | |||
There was a problem hiding this comment.
Not sure how I feel about the use of Boolean here 😄 What about just !! instead?
There was a problem hiding this comment.
I usually use Boolean cast because I think it is more explicit than using !!, and IMHO, quoting Uncle Bob:
We want code to be as expressive as possible
But if using !! is preferred for standardization reasons I can change it as well, just let me know!
There was a problem hiding this comment.
Since it's just Boolean not new Boolean, I'm OK with that! I've assumed you're instantiating a boxing type here that wraps a primitive value (instead of just coercing the value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add regex support when checking a file mime-type as requested here.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
FileTypePipe only checks against common strings.
What is the new behavior?
FileTypePipe now can check against regular expressions.
Does this PR introduce a breaking change?
Other information