Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): allow postfixId on KafkaOptions to be an empty string #9681

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented May 28, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #9677

What is the new behavior?

empty strings on postfixId option on KafkaServer and KafkaClient's constructor are allowed now

Does this PR introduce a breaking change?

  • Yes
  • No

as we're changing the behavior of a public API (ClientsModule.register)

@@ -194,6 +194,9 @@ export interface KafkaParserConfig {
export interface KafkaOptions {
transport?: Transport.KAFKA;
options?: {
/**
* Defaults to `"-server"` on server side and `"-client"` on client side.
Copy link
Member Author

@micalevisk micalevisk May 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't use @default tag here because KafkaOptions['options'] is being used by both client and server

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2a657836-8071-4fbb-bae6-3e30bf574ef4

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.107%

Totals Coverage Status
Change from base Build 2e5e4b92-9513-416d-b615-80d69061b17c: 0.0%
Covered Lines: 5781
Relevant Lines: 6143

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 31, 2022
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 June 15, 2022 09:42
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jun 15, 2022
12 tasks
@kamilmysliwiec kamilmysliwiec merged commit e3ddfaf into nestjs:9.0.0 Jun 15, 2022
@micalevisk micalevisk deleted the fix-issue-9677 branch June 15, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there any reason postfixId is forced?
4 participants