refactor(common,core): use shared utils whenever possible #8797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In several places, utilities functions declared at https://github.com/nestjs/nest/blob/939f2d56d1c9ec25108ada7053dfc51cbc6be7c2/packages/common/utils/shared.utils.ts are not used when they could be used
What is the new behavior?
Every
typeof x === y
andtypeof x !== y
was replaced with some method from@nestjs/common/utils/shared.utils.ts
fileThe only line I didn't change was the following:
nest/packages/core/router/router-module.ts
Line 45 in 259b6fb
for whatever reason, using
isFunction(routeOrType)
introduces a compile error:Does this PR introduce a breaking change?
Other information
I choose to didn' t touch any
.spec.ts
file, and only files underpackages
directory.