-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): handle errors in observable streams #8740
feat(core): handle errors in observable streams #8740
Conversation
@jmcdo29 I tried the approach of sharing logic between REST and SSE request and this is what I ended up with. This had the side effect of sharing the behavior of unsubscribing when a request is closed from REST handlers as well. Let me know if you like this direction and I can work on adding some test and docs. |
Pull Request Test Coverage Report for Build 65ceea40-0985-4f1e-b40c-0c581c2903af
💛 - Coveralls |
de2d81e
to
19fe279
Compare
fb2deb9
to
d49bed1
Compare
d49bed1
to
fc36fae
Compare
fc36fae
to
b7f3680
Compare
LGTM |
} | ||
}); | ||
|
||
return EMPTY; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should definitely forward the error and let the user do this, this doesn't allow us to do so anymore.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously when an error was thrown in an observable as part of an SSE request the server would crash.
Issue Number: #8730
What is the new behavior?
Now errors are properly handled within SSE request so that if an error occurs then an error message event is sent and the connection is closed.
Does this PR introduce a breaking change?
Breaking changes have been removed from scope
Other information