-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common,core): auto flush logs after useLogger
call
#8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build a668766f-3841-414a-ad8a-9f83e671dd53
💛 - Coveralls |
jmcdo29
requested changes
Dec 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see this added in. Left a minor comment, but the functionality itself looks fine to me
When using `NestApplicationContext` app and `autoFlushLogs` is on, invoking `useLogger` method on it must flushes its logs.
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: closes #8733
I tested it locally with the following usages -- assuming that there was a call to
app.useLogger
:flushes (even tho the aren't logs buffered).
flushes.
flushes.
do not flushes.
What is the new behavior?
When using
NestApplicationContext
app andautoFlushLogs
is on, invokinguseLogger
method on it will flushes its logs.Does this PR introduce a breaking change?
Other information
A naive attempt to address that issue without much effort. I have few concerns regarding my solution but I didn't come with anything better (nor easy to follow). Feel free to rejected it then :p