Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set name property of exception object equal to class name #5859

Conversation

DrPuneetGaur
Copy link
Contributor

@DrPuneetGaur DrPuneetGaur commented Dec 4, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

#5809

Issue Number: #5809

What is the new behavior?

Set name property of exception object equal to class name

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Added a method to set name property of exception object equal to class name which currently is always Error

Closes nestjs#5809
Added a method to set name property of exception object equal to class name which currently is always Error. Updated tests.

Closes nestjs#5809
@coveralls
Copy link

coveralls commented Dec 4, 2020

Pull Request Test Coverage Report for Build 09e02b0a-810a-49d4-99dd-4b0fe5e07c87

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.651%

Totals Coverage Status
Change from base Build 542c1a08-47ee-4033-ae37-71a04859920b: 0.0%
Covered Lines: 5008
Relevant Lines: 5291

💛 - Coveralls

Added a method to set name property of exception object equal to class name which currently is always Error. Updated tests.

Closes nestjs#5809
@DrPuneetGaur
Copy link
Contributor Author

Hi @kamilmysliwiec, I have created a PR for this issue.

@kamilmysliwiec
Copy link
Member

This introduces a potential breaking change so let's wait with merging this PR till the next major release.

@kamilmysliwiec kamilmysliwiec added this to the 8.0.0 milestone Dec 8, 2020
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 8.0.0 January 27, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants