-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set name property of exception object equal to class name #5859
Merged
kamilmysliwiec
merged 4 commits into
nestjs:8.0.0
from
DrPuneetGaur:fix-set-name-property-of-exception-object-equal-to-class-name
Jan 27, 2021
Merged
Fix set name property of exception object equal to class name #5859
kamilmysliwiec
merged 4 commits into
nestjs:8.0.0
from
DrPuneetGaur:fix-set-name-property-of-exception-object-equal-to-class-name
Jan 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method to set name property of exception object equal to class name which currently is always Error Closes nestjs#5809
Added a method to set name property of exception object equal to class name which currently is always Error. Updated tests. Closes nestjs#5809
Pull Request Test Coverage Report for Build 09e02b0a-810a-49d4-99dd-4b0fe5e07c87
💛 - Coveralls |
Added a method to set name property of exception object equal to class name which currently is always Error. Updated tests. Closes nestjs#5809
Hi @kamilmysliwiec, I have created a PR for this issue. |
This introduces a potential breaking change so let's wait with merging this PR till the next major release. |
…qual-to-class-name
3 tasks
This was referenced Jul 7, 2021
This was referenced Jul 10, 2021
Closed
This was referenced Jul 17, 2021
This was referenced Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#5809
Issue Number: #5809
What is the new behavior?
Set name property of exception object equal to class name
Does this PR introduce a breaking change?
Other information