Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(@nestjs/core): suuport async init/destroy hook #579

Closed
wants to merge 1 commit into from

Conversation

XGHeaven
Copy link

#569

I try to implement it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.993% when pulling 5d3c431 on XGHeaven:async-hook into 998a24d on nestjs:master.

@kamilmysliwiec
Copy link
Member

Hi @XGHeaven,
Thanks for your effort! In order to support async lifecycle hooks, a bit more changes have been needed (including things inside microservices and websocket module). I finished it already. Thanks for the idea, and once again, your time. 🙂

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants