-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add abortOnError option in NestApplicationContextOptions #5327
feat(core): Add abortOnError option in NestApplicationContextOptions #5327
Conversation
…' of https://github.com/princechauhan1992/nest into added-abort-on-error-in-nestapplication-context-options
@kamilmysliwiec This is my first contribution to an open source project, so I apologize in advance in case I have made any mistakes. Kindly suggest if any changes are required. |
Pull Request Test Coverage Report for Build 2b7063e7-43b1-4bfb-8314-d3471ed66c52
💛 - Coveralls |
packages/common/interfaces/nest-application-context-options.interface.ts
Outdated
Show resolved
Hide resolved
packages/common/interfaces/nest-application-context-options.interface.ts
Outdated
Show resolved
Hide resolved
I'm using NestJS 10.0.0 and still having the same issue. app.module.ts
main.ts file
I want to log bootstrap errors to an external system and in order to do so I must be able to to catch those errors explicitly. Am I missing something here?? Please help me with this. @kamilmysliwiec |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#5162
Issue Number: 5162
What is the new behavior?
An abortOnError flag is added in nestApplicationContext. By default the process is aborted, but if abortOnError is set to false,
error is rethrown instead of calling process.abort() or process.exit(1)
Does this PR introduce a breaking change?
Other information