-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sse): Implement Server-Sent Events #4842
Conversation
@@ -0,0 +1,75 @@ | |||
<p align="center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the 28-sse
? I don't think it makes sense to create a separate sample for this (likewise, we don't have dedicated samples for @Redirect()
or any similar decorators)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this @sse directive as we could see the Websocket one. I think that this may serve as a functional test or a test application to understand how it works and to understand that it can be used for real-time updates.
7bc3e00
to
e3647fa
Compare
Pull Request Test Coverage Report for Build 1eed7a91-71e0-4b54-963b-382fb2a112fe
💛 - Coveralls |
2d50017
to
9fb6ecb
Compare
The overall API looks good! Would you like to create a PR to the docs? We can add it under the "Techniques" category (as a new, dedicated page) or just add a new section in the "Controllers" chapter |
see nestjs/docs.nestjs.com#1387 lmk if I should rebase |
rebased and added docs |
Any chance this will land soon? Our team could use this feature :) |
Would you be able to test my branch and make some feedbacks? |
7131ce2
to
3909f3a
Compare
a3eabe0
to
04c689d
Compare
5ff4fbe
to
082a569
Compare
Any chance for this being merged soon? Would love to provide SSE updates to clients |
Same here! This will be a great feature add for the framework. |
Same comment as above: Would you be able to test my branch and make some feedbacks? |
b09ef75
to
8041f0f
Compare
I have benchmarks where this hits 80k req/s pushed on a single node. I'd love to know what maintainers think of this work! |
8041f0f
to
7850c9a
Compare
Thank you for this amazing contribution! This feature will be available in 7.5.0 |
Nice feature! Thank you ! |
Hello, how do you send data from a service? to an already subscribed client. i tried but observables only works in the method scope and when trying to emit data from another endpoint (for example, when another user/client is updating data) the observable just do not emit to the other client to receive the update. |
Please, use our Discord channel (support) for such questions. We are using GitHub to track bugs, feature requests, and potential improvements. |
PR Checklist
PR Type
See discussion in #4826. You can test this using the new sample 28.
Usage: