Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): enable grpc option value to accept 0 #4817

Merged

Conversation

Jekiwijaya
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

currently the logic ignore if value grpc option is 0

Issue Number: #4816

What is the new behavior?

grpc option should be able accept 0 value

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15cd463e-2437-4b10-9e30-ba44b65e06c7

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.629%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-grpc.ts 0 1 0.0%
Totals Coverage Status
Change from base Build d756523f-c85a-4bd9-827d-44fd12e77f26: 0.0%
Covered Lines: 4704
Relevant Lines: 4971

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Thank you!

@kamilmysliwiec kamilmysliwiec merged commit 55032c1 into nestjs:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants